#2565 Fixed can't find an element with id/name #2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Patrykb0802
commented
Jun 16, 2023
Patrykb0802
commented
- Added skip condition for unnamed watchlists in showUserProfileCB and saveUserProfile functions
- Deprecated updateUserProfileImg function in usersProfiles.jsp file
- Deprecated calling the function updateUserProfileImg in showUserProfileCB function
- Added skip condition for unnamed watchlists in showUserProfileCB and saveUserProfile functions - Deprecated updateUserProfileImg function in usersProfiles.jsp file - Deprecated calling the function updateUserProfileImg in showUserProfileCB function
Limraj
reviewed
Jun 19, 2023
| @@ -169,6 +169,8 @@ | |||
|
|
|||
| if(watchlists != null) { | |||
| for (i=0; i<watchlists.length; i++) { | |||
| if(watchlists[i].name == '<fmt:message key="common.newName"/>') // skip unnamed lists | |||
There was a problem hiding this comment.
This condition is in at least 3 places in this file, you can move it to a separate function:
"isUnnamed"
added 2 commits
June 20, 2023 13:12
- Added function validateWatchList that checks for unnamed watchlists
- Added function validateWatchList that checks for unnamed watchlists
Limraj
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.