Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2565 Fixed can't find an element with id/name #2568

Merged
merged 3 commits into from
Jun 20, 2023
Merged

#2565 Fixed can't find an element with id/name #2568

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87cc6de
#2565 Fixed can't find an element with id/name
Jun 16, 2023
3507d44
#2565 Fixed can't find an element with id/name
Jun 20, 2023
14137d0
#2565 Fixed can't find an element with id/name
Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions WebContent/WEB-INF/jsp/usersProfiles.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@

if(watchlists != null) {
for (i=0; i<watchlists.length; i++) {
if(watchlists[i].name == '<fmt:message key="common.newName"/>') // skip unnamed lists
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is in at least 3 places in this file, you can move it to a separate function:
"isUnnamed"

continue;
$set("wl"+ watchlists[i].id, "0");
}

Expand All @@ -187,7 +189,7 @@
}

setUserProfileMessage();
updateUserProfileImg();
//updateUserProfileImg();
}

function saveUserProfile() {
Expand Down Expand Up @@ -216,8 +218,10 @@
//populate watchlist permissions paremeters
var wlPermis = new Array();
var wlval;
if (watchlists != null){
if (watchlists != null ){
for (i=0; i<watchlists.length; i++) {
if(watchlists[i].name == '<fmt:message key="common.newName"/>') // skip unnamed lists
continue;
wlval = $get("wl"+ watchlists[i].id);

if (wlval == "1" || wlval == "2") {
Expand Down Expand Up @@ -283,11 +287,11 @@
setUserImg(true, userProfile.disabled, $("u"+ userProfile.id +"Img"));
console.log("u"+ editingUserProfileId +"Img")
}
function updateUserProfileImg() {

/*function updateUserProfileImg() {
setUserImg(true, $get("disabled"), $("userImg"));
}
}*/

function dataSourceChange(dscb) {
display("dsps"+ dscb.id.substring(2), !dscb.checked);
}
Expand Down
Loading