Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2521 Text "double click to close" inside datapoint details without need #2620

Merged
merged 2 commits into from
Jul 18, 2023
Merged

#2521 Text "double click to close" inside datapoint details without need #2620

merged 2 commits into from
Jul 18, 2023

Conversation

Patrykb0802
Copy link
Contributor

  • Added if condition in changeContentText.jsp which checks if point that is being edited is in Point Detail Menu.
  • Added hideClosingHint flag for model to use it in if condition
  • Small fix with translation

@Patrykb0802
#2521 Text "double click to close" inside datapoint details without need
82afc09 
- Added if condition in changeContentText.jsp which checks if point that is being edited is in Point Detail Menu.
- Added hideClosingHint flag for model to use it in if condition
- Small fix with translation
@Patrykb0802 Patrykb0802 added this to the 2.7.5.4 milestone Jul 17, 2023
@Patrykb0802 Patrykb0802 requested a review from Limraj July 17, 2023 16:35
@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

Java Script Mocha Unit Test Results

268 tests  ±0   268 ✔️ ±0   5s ⏱️ -1s
  70 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit b6af554. ± Comparison against base commit d12215b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

Java JUnit Test Results

2 083 tests  ±0   2 083 ✔️ ±0   26s ⏱️ -1s
     90 suites ±0          0 💤 ±0 
     90 files   ±0          0 ❌ ±0 

Results for commit b6af554. ± Comparison against base commit d12215b.

♻️ This comment has been updated with latest results.

@Patrykb0802
#2521 Text "double click to close" inside datapoint details without need
b6af554 
- Placed model.put("hideClosingHint", true); function under if condition to reduce amount of function calls
Limraj
Limraj approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@Limraj Limraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tested data point type:
  • Numeric;
  • Binary;
  • Alphanumeric;
  • Multistate;
  1. Check 'Show history from' on /app.shtm#/datapoint-details/ on new ui

@Limraj Limraj merged commit 550329e into release/2.7.5.4 Jul 18, 2023
10 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Limraj Limraj Limraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrykb0802 @Limraj