Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateStandardColorMap Refactor #2311

Merged
merged 14 commits into from Dec 10, 2021
Merged

Conversation

tarkpate
Copy link
Contributor

Changes:

  • Fixed value scaling for alpha values in ColorMap
    CreateStandardColorMap changes:
  • Set UI size to fixed and changed custom color map buttons
  • Fixed value range for color map preview so the selection range is always in [0,1]
  • Preview points can be reselected and dragged
  • Preview points can be deleted with middle mouse button too, so it can be cancelled when you haven't dropped a point yet
  • Preview points are clamped to the nearest neighbors, which solves the problem of having multiple points at the same x value

@dcwhite dcwhite self-assigned this Jul 16, 2021
@dcwhite dcwhite added this to the 5.0-beta.ϴ [Internal] milestone Jul 16, 2021
@tarkpate
Copy link
Contributor Author

Issues to test this with:

* [ ]  [Adjust alpha hues in createstandardcolormap, part 3 #2006](https://github.com/SCIInstitute/SCIRun/issues/2006)

* [ ]  [CreateStandardColorMap improvements, part 2: improve performance of GUI #1349](https://github.com/SCIInstitute/SCIRun/issues/1349)

* [ ]  [SCIRun crashes when changing the colormaps #1127](https://github.com/SCIInstitute/SCIRun/issues/1127)

Thanks for linking those. We should be able to close #2006 with this. I'll test performance on my old macbook to see if it's still necessary. I didn't get any crashes on linux, so I'll test Mac

Copy link
Member

@dcwhite dcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-12-10 at 2 24 57 PM

Screen Shot 2021-12-10 at 2 22 49 PM

Layout of the UI needs some fixing on Mac (and likely elsewhere)

@dcwhite
Copy link
Member

dcwhite commented Dec 10, 2021

Top is PR, bottom is original.

@dcwhite dcwhite merged commit 76cd8bb into SCIInstitute:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Renderer/Visualization
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants