Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlipSurfaceNormals Algo/Module #724

Closed
wants to merge 4 commits into from

Conversation

mhansen1
Copy link
Contributor

The updated version of FlipSurfaceNormals that will build in Visual Studio 2013. Had to create a new branch because the bin/.gitignore got deleted and it wouldn't let me recreate/commit a replaced version.

The updated version of FlipSurfaceNormals that will build in Visual
Studio 2013
@a-y-khan
Copy link

If this happens again, you can use 'git checkout -- bin' to restore the deleted bin directory.
Sent using CloudMagic
On Tue, Dec 09, 2014 at 6:16 PM, mhansen1 notifications@github.com wrote: The updated version of FlipSurfaceNormals that will build in Visual Studio 2013. Had to create a new branch because the bin/.gitignore got deleted and it wouldn't let me recreate/commit a replaced version.

You can merge this Pull Request by running
git pull https://github.com/mhansen1/SCIRun modules_conversion
Or view, comment on, or merge it at:
  #724

Commit Summary

FlipSurfaceNormals Algo/Module

File Changes

M
src/Core/Algorithms/Factory/HardCodedAlgorithmFactory.cc
(2)


M
src/Core/Algorithms/Legacy/Fields/CMakeLists.txt
(3)


M
src/Core/Algorithms/Legacy/Fields/MeshData/FlipSurfaceNormals.cc
(138)


M
src/Core/Algorithms/Legacy/Fields/MeshData/FlipSurfaceNormals.h
(27)


M
src/Modules/Factory/ModuleFactoryImpl1.cc
(2)


M
src/Modules/Legacy/Fields/CMakeLists.txt
(3)


M
src/Modules/Legacy/Fields/FlipSurfaceNormals.cc
(84)


A
src/Modules/Legacy/Fields/FlipSurfaceNormals.h
(59)

Patch Links:

https://github.com/SCIInstitute/SCIRun/pull/724.patch
https://github.com/SCIInstitute/SCIRun/pull/724.diff

—Reply to this email directly or view it on GitHub.

@dcwhite dcwhite self-assigned this Dec 10, 2014
@dcwhite dcwhite added this to the 5.0-alpha.M [Internal] milestone Dec 10, 2014
The CMakeLists and factory files with BuildNoiseColumnMatrix added in.
Progress so far on BuildNoiseColumnMatrix files. Everything is working
except that what is generated doesn't seem to be truly random.
Everything seems to be working OK, now. Will generate a new set of
values every time it is executed.
@dcwhite
Copy link
Member

dcwhite commented Dec 16, 2014

@mhansen1 Also, make sure you make a new branch for each topic/pull request. Adding more commits to this branch broke the build and made the PR incoherent. I'll close it, you'll need to create another.

@dcwhite dcwhite closed this Dec 16, 2014
@dcwhite dcwhite removed this from the 5.0-alpha.M [Internal] milestone Dec 16, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4fa87b8 on mhansen1:modules_conversion into * on SCIInstitute:vs2013*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants