Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTest DEPENDS property #435

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Add CTest DEPENDS property #435

merged 3 commits into from
Jun 22, 2024

Conversation

bobpaw
Copy link
Collaborator

@bobpaw bobpaw commented Jun 21, 2024

  • CMake test property DEPENDS has been added to the appropriate tests to facilitate parallel testing.
  • Some tests require other tests to run first to operate on their output (split -> collapse, etc). Previously, tests would fail once and then succeed on a second ctest run. Now in parallel those tests wait for what they need, allowing tests to pass the first time.

@bobpaw
feat: CTest dependent tests are marked as such
79e3317 
- CMake test property DEPENDS has been added to the appropriate tests to
  facilitate parallel testing.
- Some tests require other tests to run first to operate on their output
  (split -> collapse, etc). Previously, tests would fail once and then
  succeed on a second ctest run. Now in parallel those tests wait for
  what they need, allowing tests to pass the first time.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw bobpaw added the cmake label Jun 21, 2024
@bobpaw bobpaw requested review from cwsmith and removed request for cwsmith June 21, 2024 18:21
@bobpaw
Add simmetrix dependent test
aeebcca 
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@bobpaw
Copy link
Collaborator Author

bobpaw commented Jun 21, 2024

Some Simmetrix tests are failing but they were also failing before these changes.

@bobpaw
Add simmetrix dependent test
d68636e 
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
@cwsmith
Copy link
Contributor

cwsmith commented Jun 21, 2024

/runtests

@github-actions GitHub Actions
Copy link

Test Result: failure (details)

@cwsmith
Copy link
Contributor

cwsmith commented Jun 21, 2024

@bobpaw Thank you for the changes. The failing tests are the same as those listed here: #434

Does the CMake minimum version:

core/CMakeLists.txt

Line 7 in d68636e

cmake_minimum_required(VERSION 3.8)
need to be increased to support the DEPENDS property?

@bobpaw
Copy link
Collaborator Author

bobpaw commented Jun 21, 2024

@bobpaw Thank you for the changes. The failing tests are the same as those listed here: #434

Does the CMake minimum version:

core/CMakeLists.txt

Line 7 in d68636e

cmake_minimum_required(VERSION 3.8)

need to be increased to support the DEPENDS property?

No, based on this documentation it has been around since CMake 3.0:
https://cmake.org/cmake/help/v3.0/prop_test/DEPENDS.html

@bobpaw bobpaw requested a review from cwsmith June 21, 2024 20:42
@bobpaw bobpaw merged commit 414d9c2 into develop Jun 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwsmith cwsmith cwsmith approved these changes

Assignees
No one assigned
Labels
cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobpaw @cwsmith