Shared pointers with arrays are c++17 feature #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using shared pointers with arrays is a c++ 17 feature. For compatibillty with gcc/6.3.0 we need to only support pure c++14 features.
|
@dhyan1272 This needed on other small fix as functions that contain All of the tests are passing with |
|
@joshia5 when you get a chance can you take a look? |
|
@jacobmerson looks good. Is this commit 709f6d8 |
|
It's related in the sense that I didn't test my last pull request with CUDA and that ended up causing compilation issues. However all of the changes here are related to building with the CUDA backend so I figured it was fine to leave the commit here. I can open a separate pull request if you prefer. |
joshia5
approved these changes
Jun 7, 2022
|
Looks good to me either way. Is this ready merge in now? @jacobmerson or are you waiting to hear back from dhyan if it needs other changes for the gitrm build? |
|
@joshia5 I think you can go ahead and merge it. I didn't hear back from dhyan either here or on the email chain we had. |
|
So, the build issues is gitrm was due to the gcc version we had to use (gcc 6.3.0) for compiling omega-h, (due to the limitation of cuda 9.0 being supported by gcc<=6). Had no issues in building omega-h with either gcc >=9
Regards,
Dhyan
Mechanical Aerospace and Nuclear Engineering
…________________________________
From: Aditya Joshi ***@***.***>
Sent: Tuesday, June 7, 2022 3:27 PM
To: SCOREC/omega_h ***@***.***>
Cc: dhyan1272 ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [SCOREC/omega_h] Shared pointers with arrays are c++17 feature (PR #35)
Looks good to me either way. Is this ready merge in now? @jacobmerson<https://github.com/jacobmerson> or are you waiting to hear back from dhyan if it needs other changes for the gitrm build?
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANF4KFQJXTQQTDOCNBE3F63VN6PCDANCNFSM5YAMIPQQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@dhyan1272 you can check if this now builds with |
|
That would be great,
Will let you know by tonight.
Regards
Dhyan
From: Jacob ***@***.***>
Sent: Tuesday, June 7, 2022 4:03 PM
To: ***@***.***>
Cc: ***@***.***>; ***@***.***>
Subject: [EXTERNAL] Re: [SCOREC/omega_h] Shared pointers with arrays are c++17 feature (PR #35)
@dhyan1272<https://github.com/dhyan1272> you can check if this now builds with ***@***.*** (with Omega_h with CUDA) I don't think it will work with Kokkos since something in Kokkos was crashing nvcc. This commit fixes the error that you send me an email about.
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANF4KFRG35OHQI6IA6KZW4DVN6TJZANCNFSM5YAMIPQQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Building with CUDA without kokkos and gcc -6.3.0 gives errors like
========================================
nvcc error : 'cicc' died due to signal 11 (Invalid memory reference)
nvcc error : 'cicc' core dumped
make[2]: *** [src/CMakeFiles/omega_h.dir/Omega_h_rcFields.cpp.o] Error 139
========================================
Building without CUDA / kokkos and with gcc-6.3.0 gives errors like
===========================================================
/fusion/usc/opt/gcc/gcc-6.3.0/include/c++/6.3.0/bits/unique_ptr.h:158:17: note: candidate expects 0 arguments, 1 provided
In file included from /home/nathd/omega_h/src/Omega_h_array.hpp:4:0,
from /home/nathd/omega_h/src/Omega_h_comm.hpp:7,
from /home/nathd/omega_h/src/Omega_h_array_ops.hpp:6,
from /home/nathd/omega_h/src/Omega_h_rcFields.cpp:4:
/home/nathd/omega_h/src/Omega_h_defines.hpp: In instantiation of ‘auto Omega_h::apply_to_omega_h_types(Omega_h_Type, const F&) [with F = Omega_h::Mesh::get_rc_mesh_tag_from_rc_tag(Omega_h::Int, const Omega_h::TagBase*)::<lambda(auto:1)>]’:
/home/nathd/omega_h/src/Omega_h_rcFields.cpp:340:4: required from here
/home/nathd/omega_h/src/Omega_h_defines.hpp:93:15: error: use of ‘Omega_h::Mesh::get_rc_mesh_tag_from_rc_tag(Omega_h::Int, const Omega_h::TagBase*)::<lambda(auto:1)> [with auto:1 = int]’ before deduction of ‘auto’
return f(I32{});
~^~~~~~~
/home/nathd/omega_h/src/Omega_h_defines.hpp:93:21: error: return-statement with a value, in function returning 'void' [-fpermissive]
return f(I32{});
^
/home/nathd/omega_h/src/Omega_h_defines.hpp:97:15: error: use of ‘Omega_h::Mesh::get_rc_mesh_tag_from_rc_tag(Omega_h::Int, const Omega_h::TagBase*)::<lambda(auto:1)> [with auto:1 = long int]’ before deduction of ‘auto’
return f(I64{});
=====================================================================
Regards,
Dhyan
Mechanical Aerospace and Nuclear Engineering
…________________________________
From: Dhyanjyoti Nath ***@***.***>
Sent: Tuesday, June 7, 2022 4:05 PM
To: SCOREC/omega_h ***@***.***>; SCOREC/omega_h ***@***.***>
Cc: dhyan1272 ***@***.***>; Mention ***@***.***>
Subject: RE: [EXTERNAL] Re: [SCOREC/omega_h] Shared pointers with arrays are c++17 feature (PR #35)
That would be great,
Will let you know by tonight.
Regards
Dhyan
From: Jacob ***@***.***>
Sent: Tuesday, June 7, 2022 4:03 PM
To: ***@***.***>
Cc: ***@***.***>; ***@***.***>
Subject: [EXTERNAL] Re: [SCOREC/omega_h] Shared pointers with arrays are c++17 feature (PR #35)
@dhyan1272<https://github.com/dhyan1272> you can check if this now builds with ***@***.*** (with Omega_h with CUDA) I don't think it will work with Kokkos since something in Kokkos was crashing nvcc. This commit fixes the error that you send me an email about.
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANF4KFRG35OHQI6IA6KZW4DVN6TJZANCNFSM5YAMIPQQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Closed
|
Thanks!
we had a meeting today regarding these issues.
gcc 6.3.0 / cuda 9.0 with such an old gpu card (compute capability of 3.5) may not be very suitable for performance.
So, building with CUDA on those systems is on hold now and we may look for other options.
Regards,
Dhyan
Mechanical Aerospace and Nuclear Engineering
…________________________________
From: Jacob Merson ***@***.***>
Sent: Monday, June 6, 2022 3:11 PM
To: SCOREC/omega_h ***@***.***>
Cc: dhyan1272 ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] [SCOREC/omega_h] Shared pointers with arrays are c++17 feature (PR #35)
Using shared pointers with arrays is a c++ 17 feature. For compatibillty with gcc/6.3.0 we need to only support pure c++14 features.
@dhyan1272<https://github.com/dhyan1272>
________________________________
You can view, comment on, or merge this pull request online at:
#35
Commit Summary
* 6b72e42<6b72e42> Shared pointers with arrays are c++17 feature
File Changes
(2 files<https://github.com/SCOREC/omega_h/pull/35/files>)
* M src/Omega_h_array.cpp<https://github.com/SCOREC/omega_h/pull/35/files#diff-c2459e2761c98cdfdad3c7229132b63a91b146f5aaa3c13f19338f1da2692da7> (10)
* M src/Omega_h_array.hpp<https://github.com/SCOREC/omega_h/pull/35/files#diff-d957db98978ea0d49aa1fca35820e7ea68bfcc3297902db6c0bde5487f2d4857> (8)
Patch Links:
* https://github.com/SCOREC/omega_h/pull/35.patch
* https://github.com/SCOREC/omega_h/pull/35.diff
—
Reply to this email directly, view it on GitHub<#35>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANF4KFTXK64XIXILB6E5F3TVNZEPZANCNFSM5YAMIPQQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using shared pointers with arrays is a c++ 17 feature. For compatibillty with gcc/6.3.0 we need to only support pure c++14 features.
@dhyan1272