Add Mesh2D #87
Merged
Add Mesh2D #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added osh2vtk2d that fails if mesh is not 2D
- Renamed osh2vtk2d to load_2d
Test originally failed because it attempted to load an invalid mesh due to a change in how arguments are handled for tests that are expected to fail. Now the test fails because we are attempting to load a 3d mesh into a 2d mesh
…sts with CMake wrapper Fixed load_2d
cwsmith
requested changes
Feb 16, 2024
cwsmith
reviewed
Feb 16, 2024
Co-authored-by: Cameron Smith <cwsmith@users.noreply.github.com>
cwsmith
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
Mesh2Da child class ofMeshthat only allows 2D geometry. It also adds a test case for attempting to load higher dimension geometry into aMesh2Dwhich is expected to fail. To facilitate this,test_func_implwas updated to run tests in a modified environment such that system-level errors can be caught. (i.e a failedassert).