Prevent TypeError with None in error message #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into a problem where SCons was generating an error that contained a None (don't ask me how), and this got passed through to_str() which caused a TypeError because None isn't a bytes-like object. I fixed it two ways: enable to_str and to_bytes to handle None without complaint, and change Errors.py to use to_String() instead of to_str(), since it seems more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where SCons was generating an error that
contained a None (don't ask me how), and this got passed through
to_str() which caused a TypeError because None isn't a bytes-like
object.
I fixed it two ways: enable to_str and to_bytes to handle None without
complaint, and change Errors.py to use to_String() instead of to_str(),
since it seems more robust.