Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt fixing TestSCons.where_is() for win32 #3236

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

ptomulik
Copy link
Contributor

@ptomulik ptomulik commented Nov 6, 2018

When using testing framework for external tests (-e), the method TestSCons.where_is() seems to always return None under win32. This PR fixes this. Tested with one of my projects on appveyor.

@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 6, 2018

Can you point to URL for your appveyor results before/after this change?

@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 6, 2018

Can you point to URL for your appveyor results before/after this change?

This job, for example, used the patched testing framework:

https://ci.appveyor.com/project/ptomulik/scons-tool-dvipdfm/builds/20088248/job/i2ke4pfn50uxi481

no skipped tests (means, where_is() detected correctly), while this

https://ci.appveyor.com/project/ptomulik/scons-tool-dvipdfm/builds/20089404/job/4tuf3jdfh6omkv95

uses unpatched testing framework -- three tests skipped (same programs not found by where_is()) .

@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 6, 2018

This was the project under test: https://github.com/ptomulik/scons-tool-dvipdfm/tree/0.1.0/

@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 6, 2018

From travis-ci (Build system information):

clang version
clang version 7.0.0 (tags/RELEASE_700/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/clang-7.0.0/bin

looks like they changed default version of clang on Xenial to '7.0.0' . The .travis/install.sh symlinks '5.0.0', but it seems to make clang tests to fail at later stage.

@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 6, 2018

Good catch on clang. was just digging in.
It appears py3.7-dev image only no longer has clang version we're pointing to.. I'll update the travis file

@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 6, 2018

rebase from master?

@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 6, 2018

rebase from master?

yes, just did it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 79.917% when pulling 210b61f on ptomulik:whereis into 9685d23 on SCons:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 79.917% when pulling 210b61f on ptomulik:whereis into 9685d23 on SCons:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 79.917% when pulling 210b61f on ptomulik:whereis into 9685d23 on SCons:master.

@bdbaddog
Copy link
Contributor

bdbaddog commented Nov 9, 2018

Clear Ci. Merging

@bdbaddog bdbaddog merged commit bccc8cf into SCons:master Nov 9, 2018
@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 9, 2018

Thanks!

@ptomulik ptomulik deleted the whereis branch November 9, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants