-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt fixing TestSCons.where_is() for win32 #3236
Conversation
Can you point to URL for your appveyor results before/after this change? |
This job, for example, used the patched testing framework: https://ci.appveyor.com/project/ptomulik/scons-tool-dvipdfm/builds/20088248/job/i2ke4pfn50uxi481 no skipped tests (means, where_is() detected correctly), while this https://ci.appveyor.com/project/ptomulik/scons-tool-dvipdfm/builds/20089404/job/4tuf3jdfh6omkv95 uses unpatched testing framework -- three tests skipped (same programs not found by where_is()) . |
This was the project under test: https://github.com/ptomulik/scons-tool-dvipdfm/tree/0.1.0/ |
From travis-ci (Build system information):
looks like they changed default version of clang on Xenial to '7.0.0' . The |
Good catch on clang. was just digging in. |
rebase from master? |
yes, just did it. |
2 similar comments
Clear Ci. Merging |
Thanks! |
When using testing framework for external tests (
-e
), the methodTestSCons.where_is()
seems to always returnNone
under win32. This PR fixes this. Tested with one of my projects on appveyor.