-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): bump junit-pioneer from 1.6.2 to 1.7.0 #1555
fix(deps): bump junit-pioneer from 1.6.2 to 1.7.0 #1555
Conversation
@dependabot recreate |
df68230
to
fa30388
Compare
@dependabot rebase |
Bumps [junit-pioneer](https://github.com/junit-pioneer/junit-pioneer) from 1.6.2 to 1.7.0. - [Release notes](https://github.com/junit-pioneer/junit-pioneer/releases) - [Commits](junit-pioneer/junit-pioneer@v1.6.2...v1.7.0) --- updated-dependencies: - dependency-name: org.junit-pioneer:junit-pioneer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
fa30388
to
55d418a
Compare
This change makes this test fail. |
I fixed the test case in this commit. In my opinion that is not a perfect solution. The need of this change also implies that we are causing a breaking change for our consumers with the update to junit-pioneer 1.7.0. This breaking change affects all consumers that have a similar test setup with a Dropwizard app and one of the affected extensions. I'm not sure how many services are affected and if that could be mitigated as simple as here. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
A newer version of org.junit-pioneer:junit-pioneer exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
solution in progress, let's wait for a new version based on junit-pioneer/junit-pioneer#641 |
@dependabot recreate |
Superseded by #1957. |
Bumps junit-pioneer from 1.6.2 to 1.7.0.
Release notes
Sourced from junit-pioneer's releases.
Commits
fafb0f8
Fix Java version for release build (#620)9ba0a8c
Update dependencies and build pluginsc77441b
Add version for display-names in RetryingTest (#601)a1ba44a
Support JSON sources for parametrized tests (#101 / #492)a61ca4b
Fix compiler warnings (#565)9a90140
Inherit default locale and timezone annotations (#456 / #615)19cdcb9
Remove CLA (#591 / #616)abfe61b
Align use of extension point (#479 / #496)ecb726c
Update JUnit to 5.8 (#594 / #612)90129df
Update to JDK 11 (#606 / #608)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)