feat(server-dropwizard): support configuration overrides from environment variables #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhenneke
force-pushed
the
feat/environment-variables
branch
2 times, most recently
from
c37c8e2
to
096b992
Compare
…ment variables Dropwizard supports configuration overrides by system properties (-D dw.my.property=new-value). This change supports the same name schema in environment variables (export dw.my.property=new-value).
…ting systems In Windows, System.genenv(String name) worked, but the result of System.getenv() didn't include the set variables.
dhenneke
force-pushed
the
feat/environment-variables
branch
from
096b992
to
b4dd214
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
I would close this PR since env variables are not really recommended from Java 16+. Okay for you @JoergSiebahn? |
|
As discussed: Maybe we can support a scheme like |
|
Leaving one more comment / thought here: Might be a good idea to bring our Dropwizard Commons closer to the configuration possibilities of Spring applications that are based on sda-spring-boot-commons. This would probably mean:
|
|
superseded by #2685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropwizard supports configuration overrides by system properties (
-D dw.my.property=new-value). This change supports the same name schema in environment variables (export dw.my.property=new-value).