Replace if judge with MAX() function in scale less than 1 #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
reviewed
Apr 26, 2019
dreampiggy
approved these changes
Apr 26, 2019
zhongwuzw
reviewed
May 12, 2019
| @@ -83,10 +83,7 @@ - (UIImage *)decodedImageWithData:(NSData *)data options:(nullable SDImageCoderO | |||
| CGFloat scale = 1; | |||
| NSNumber *scaleFactor = options[SDImageCoderDecodeScaleFactor]; | |||
| if (scaleFactor != nil) { | |||
There was a problem hiding this comment.
@kinarob I think you can even remove all these nil check, just one line scale = MAX([scaleFactor doubleValue], 1);. 😄
kinarobin
deleted the
Replace_MAX_function_with_if_judge_in_scale_less_than_1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
It does not change any logic in the code, Just to make the code in a pithy style！