Refactory AnimatedImageView with player backend, supports more rendering target like WatchKit/SwiftUI #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that Static function
…refactory of `Progressive Animated Loading`
… calculation logic into `SDAnimatedPlayer`. Refactory the animated progressive implementation to directly get the coder
dreampiggy
force-pushed
the
refactory_animated_player_phase2
branch
2 times, most recently
from
e0bb013
to
a857762
Compare
Codecov Report
@@ Coverage Diff @@
## master #2882 +/- ##
==========================================
+ Coverage 84.13% 84.21% +0.08%
==========================================
Files 63 65 +2
Lines 6346 6393 +47
==========================================
+ Hits 5339 5384 +45
- Misses 1007 1009 +2
Continue to review full report at Codecov.
|
dreampiggy
force-pushed
the
refactory_animated_player_phase2
branch
from
a857762
to
6a3f975
Compare
kinarobin
approved these changes
Nov 5, 2019
This was referenced Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: #2867 #2861
Pull Request Description
Feature Proposal see #2861.
This is the real implementation of that refactory, now we can use
SDAnimatedImagePlayerto support more common usage, for example:SDAnimartedImageViewwhich force main queueExtra Changes
During this refactory, there are also a solution change for our current
Progressive Animated Loading.Now, the animated player directly get the coder, such as
SDImageGIFCoder, so that it don't need previously check of image data (That's a little suck on performance because of NSData subdata compare).This PR also move those utils method
SDDeviceTotalMemoryandSDDeviceFreeMemoryinto a new private headerSDDeviceHelper.h, make it easy for code maintain and readability.CC @kinarobin