Fix the maxPixelSize logic issue will cause a upscale in SDImageIOAnimatedCoder
#3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😢 Seems I forgot that the logic in Animnated Coders.. |
dreampiggy
approved these changes
Jun 23, 2020
|
Can we add a Unit Test case to avoid this silly problem ? A check to pass a large size (10000x10000) to image which contains only 1000x1000 pixels and have a assert check. |
|
I'll added one after this PR been merged. |
|
This PR seems not update the logic below your diff code 😂. My review fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This change is based on #3015, which fix the issue of
maxPixelSizelogic check in SDImageIOCoder.m. However, for other coder like HEICCoder that used SDImageIOAnimatedCoder as base class, the issue is not resolved. So I fix it and hope to ship the fix on 5.8.2