Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the prefetcher's output logging. #387

Closed
wants to merge 1 commit into from

Conversation

jparise
Copy link
Contributor

@jparise jparise commented May 7, 2013

While useful during development, there isn't a benefit to having this
logging in a production build.

This class already exposes enough information for this type of logging
(or similar instrumentation) to be implemented externally, perhaps
with a wrapper class, for those applications that need it.

While useful during development, there isn't a benefit to having this
logging in a production build.

This class already exposes enough information for this type of logging
(or similar instrumentation) to be implemented externally, perhaps
with a wrapper class, for those applications that need it.
@andyvb
Copy link

andyvb commented Jun 18, 2013

👍

@rs
Copy link
Member

rs commented Jun 18, 2013

Would be nice to keep it in DEBUG macro conditions.

@jparise
Copy link
Contributor Author

jparise commented Jun 19, 2013

I considered keeping it for DEBUG, but it still felt too noisy for that environment. (I often prefetch 50+ images) That's a matter of personal opinion, of course.

If you feel strongly about retaining some level of debug-level output, I think a good compromise would be logging only the summary line in DEBUG builds.

@andyvb
Copy link

andyvb commented Jun 19, 2013

I would prefer to be able to turn it on or off, perhaps via a property. Even in debug I don't always want to see logging. Since you already have a way to call it with a completion block, a developer could use that instead (granted it would require a recompile). Or maybe add a method signature which returns an NSError for a failure case, since other than count for success it's the only additional info one might usually care about.

@pieterclaerhout
Copy link
Contributor

Have a look at #577.

This pull request adds a delegate for the image prefetcher. This way, everybody can choose what he/she thinks is the best approach.

@bpoplauschi
Copy link
Member

Fixed by #551 plus #721, same as #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants