Removing logging: (Issue #499) #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al finished/skip count they still have the completion block.
|
I agree, there is no need for that verbose logging. |
Merge branch 'master' of https://github.com/rs/SDWebImage
…lly take care of the reason that we forked our own version (unnecessarily verbose logging), so we'll just be using the rs/ master branch of sdwebimage from here on out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging in the prefetcher was kind of verbose and also being sent to the console, with no developer control. The status reporting upon completion was also largely redundant with the completion block, if the user of the library really wants the final status reported