Js calculator post #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrserc
reviewed
Feb 4, 2019
_posts/2019-02-04-js-calculator.html
Outdated
| demolink: "-SITE_URL-/projects/vanilla-js-calculator/index.html" | ||
| --- | ||
| <p> | ||
| It had been a while since I made anything using javascript. As an exercise I reproduced as much of the windows calculator functionality as possible. |
There was a problem hiding this comment.
It had been a while since I made anything using javascript. As an exercise, I reproduced as much of the windows calculator functionality as possible.
_posts/2019-02-04-js-calculator.html
Outdated
| I decided against using a framework because I wanted to focus on javascript instead of some framework. Using a framework might have made this easier but the focus of the exercise would have been different. | ||
| </p> | ||
| <p> | ||
| While I was at it I also decided to write tests and to generate reports about my tests. |
There was a problem hiding this comment.
While I was at it, I also decided to write tests and to generate reports about my tests.
_posts/2019-02-04-js-calculator.html
Outdated
| <h2>Jasmine</h2> | ||
|
|
||
| <p> | ||
| From previous experience i learned that, without realizing it, you will break your own application. |
There was a problem hiding this comment.
From previous experience, I learned that, without realizing it, you will break your own application.
_posts/2019-02-04-js-calculator.html
Outdated
|
|
||
| <p> | ||
| From previous experience i learned that, without realizing it, you will break your own application. | ||
| To make sure I could break pieces without knowing about it something was required to verify that every piece of code worked as expected. |
There was a problem hiding this comment.
To make sure I could break pieces without knowing about it, something was required to verify that every piece of code worked as expected.
--> not sure if you meant what you said? "To make sure I could break pieces without knowing about it,"?
_posts/2019-02-04-js-calculator.html
Outdated
| "Jasmine is a behavior-driven development framework for testing JavaScript code." | ||
| </p> | ||
| <p> | ||
| In practice, this means that anytime I modified my code Jasmine would tell me whether or not my code still worked. There's a catch though, I have to tell Jasmine what to test. This means that if I forget something or I make a mistake in one of my tests, this will be reflected in the report. |
There was a problem hiding this comment.
In practice, this means that anytime I modified my code Jasmine would tell me whether or not my code still worked. There's a catch though: I have to tell Jasmine what to test. This means that if I forget something or I make a mistake in one of my tests, this will be reflected in the report.
_posts/2019-02-04-js-calculator.html
Outdated
| In practice, this means that anytime I modified my code Jasmine would tell me whether or not my code still worked. There's a catch though, I have to tell Jasmine what to test. This means that if I forget something or I make a mistake in one of my tests, this will be reflected in the report. | ||
| </p> | ||
| <p> | ||
| A best practices when writing tests for your code is to write them before you write the code that will be tested. |
There was a problem hiding this comment.
A best practice when writing tests for your code is to write them before you write the code that will be tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.