Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI/CD sequential testing #64

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Fix CI/CD sequential testing #64

merged 1 commit into from
Mar 19, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 19, 2022 •
edited
Loading

Description

This fix replaces the following missing statement for setting sequential testing in line 118 in .github/workflows/node.js.yml:

max-parallel: 1

This fix applies to CI and CD for push and manual workflow dispatch events for the main branch in the main repository.

Related Issue

Solves #63

Type of change

  • Bug fix

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

@R055A R055A added the bug Something isn't working label Mar 19, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 19, 2022
@R055A R055A requested a review from a team as a code owner March 19, 2022 05:18
@R055A R055A self-assigned this Mar 19, 2022
@R055A R055A added this to In progress in Team 5 - Assignment 1 - Backend via automation Mar 19, 2022
@R055A R055A linked an issue Mar 19, 2022 that may be closed by this pull request
Fix CI/CD Workflow for Main Repository #63
Closed
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 19, 2022
@R055A R055A merged commit bc9c971 into SE701-T5:main Mar 19, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 19, 2022
@R055A R055A deleted the fix-ci-sequential-testing branch March 19, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopher-alba christopher-alba christopher-alba approved these changes

Assignees

@R055A R055A

Labels
bug Something isn't working
Projects
No open projects
Team 5 - Assignment 1 - Backend
Done
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Fix CI/CD Workflow for Main Repository
2 participants
@R055A @christopher-alba