Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Banner popup component #159

Closed
KirstyGong opened this issue Mar 24, 2022 · 3 comments
Closed

Edit Banner popup component #159

KirstyGong opened this issue Mar 24, 2022 · 3 comments
Assignees
@KirstyGong
Labels
bau priority: business as usual feature New feature front-end related to front-end code
Projects
Frontend-A2

Comments

@KirstyGong
Copy link
Collaborator

KirstyGong commented Mar 24, 2022 •
edited by scorpionknifes

Is your feature request related to a problem? Please describe.
The users wants to change customize the banner.

Describe the solution you'd like
Use a MUI dialog to produce a pop up and grid for positioning things.

image

Describe alternatives you've considered
N/A

Additional context
N/A
@KirstyGong KirstyGong added feature New feature front-end related to front-end code bau priority: business as usual labels Mar 24, 2022
@KirstyGong KirstyGong self-assigned this Mar 24, 2022
@KirstyGong
Copy link
Collaborator Author

@scorpionknifes @shreyasingaraju Review plz, thank you

@scorpionknifes
Copy link
Collaborator

LGTM

@scorpionknifes scorpionknifes added this to To do in Frontend-A2 via automation Mar 24, 2022
@shreyasingaraju
Copy link
Collaborator

Lgtm!

KirstyGong added a commit that referenced this issue Mar 27, 2022
@KirstyGong
[#159] banner popup (#176)
975cf0b 
* banner setting pop up

* cypress test

* Changed to controller and view style

* remove cypress video and added into git ignore
Frontend-A2 automation moved this from To do to Done Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirstyGong KirstyGong

Labels
bau priority: business as usual feature New feature front-end related to front-end code
Projects
Frontend-A2
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scorpionknifes @shreyasingaraju @KirstyGong