Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/bsync import #2196

Merged
merged 2 commits into from May 1, 2020
Merged

Patch/bsync import #2196

merged 2 commits into from May 1, 2020

Conversation

macintoshpie
Copy link
Contributor

Any background context you want to provide?

I broke some things...

What's this PR do?

Fixes the following:

  1. importing tax-lots would result in the user getting continually redirected to the data mapping page. This should no longer happen
  2. forces all bsync files in uploaded zip to have valid schemaLocations before moving to mapping page

How should this be manually tested?

  1. upload example PM spreadsheet, make all fields tax lot. You should be able to import normally
  2. upload example PM spreadsheet, make all fields property. Should import normally
  3. upload ex_1_no_schemaLocation_and_ex_1.zip and it should error immediately and not take you to the mapping page
  4. upload a normal bsync file and it should work normally
  5. upload ex_1_and_buildingsync_ex01_measures.zip and it should upload both properties normally

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.097% when pulling ce3c3c6 on patch/bsync-import into 22c8622 on bricr-dev.

Copy link
Contributor

@adrian-lara adrian-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Code changes make sense and seem to align with those made on develop.

@adrian-lara adrian-lara merged commit 0ccaa25 into bricr-dev May 1, 2020
@adrian-lara adrian-lara deleted the patch/bsync-import branch May 1, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants