Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(building_file): update buildingfile property state to link scenarios #2205

Merged
merged 2 commits into from May 11, 2020

Conversation

macintoshpie
Copy link
Contributor

@macintoshpie macintoshpie commented May 8, 2020

Any background context you want to provide?

Bug: update with buildingsync resulted in scenarios from new file not getting linked to new property state

What's this PR do?

Fixes that

Also adds tests for BuildingFile that were taken from the bricr branch

How should this be manually tested?

  • Upload bricr workflow buildingsync file, verify scenarios were uploaded on the property details page. Also go to Meters page and verify that you see the meter data and can filter by scenario.
  • Do an "Update with buildingsync" with the same file again, and verify you still see scenarios as well as the meter data
  • Do an "Update with buildingsync" with ex1.xml (has no scenarios or meter data) and the scenarios and meters should not be shown (they are no longer linked to the current property state)

@coveralls
Copy link

coveralls commented May 8, 2020

Coverage Status

Coverage increased (+0.09%) to 77.622% when pulling 1508222 on patch/buildingfile-scenario-link into 74b48be on develop.

@macintoshpie macintoshpie marked this pull request as draft May 11, 2020 15:48
@macintoshpie macintoshpie marked this pull request as ready for review May 11, 2020 18:07
Copy link
Contributor

@adrian-lara adrian-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - code changes were very similar to the bricr-dev-version of this PR.

I tested the "Update with BuildingSync" in both cases where scenarios & meters should and shouldn't be created.

@macintoshpie macintoshpie merged commit 3ab755a into develop May 11, 2020
@macintoshpie macintoshpie deleted the patch/buildingfile-scenario-link branch May 11, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants