Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube test #2214

Merged
merged 9 commits into from May 13, 2020
Merged

Kube test #2214

merged 9 commits into from May 13, 2020

Conversation

aviveiros11
Copy link
Contributor

Any background context you want to provide?

This PR is related to the ongoing development of a Kubernetes deployment for the SEED platform

What's this PR do?

This PR merges the existing chart configurations for SEED in a k8's environment

@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage remained the same at 77.622% when pulling 8185d90 on kube_test into 3ab755a on develop.

@aviveiros11
Copy link
Contributor Author

@adrian-lara, @axelstudios, @nllong - Am I able to just merge this? It was just adding the k8's charts and did not touch any other part of the codebase :)

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One quick question, otherwise merge away.

- name: POSTGRES_USER
value: seed
- name: SECRET_KEY
value: ARQV8qGuJKH8sGnBf6ZeEdJQRKLTUhsvEcp8qG9X9sCPXvGLhdxqnNXpZcy6HEyf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is just a random string of characters and not one of our actual secret keys?

@aviveiros11 aviveiros11 merged commit 19aa7c9 into develop May 13, 2020
@nllong nllong deleted the kube_test branch May 14, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants