2254 api v3 misc #2276
Merged
2254 api v3 misc #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 30, 2020 11:57
adrian-lara
force-pushed
the
2254_api_v3_misc
branch
from
627a2ba
to
effd4f7
Compare
macintoshpie
approved these changes
Jun 30, 2020
seed/views/v3/tax_lot_properties.py
Outdated
| 'export_type': 'string', | ||
| 'profile_id': 'integer' | ||
| }, | ||
| description="Valid export_types: 'csv', 'geojson', 'xlsx' (defaulting to 'csv')" |
There was a problem hiding this comment.
Might be nice to add docs on the specific properties of the request body
seed/views/v3/portfolio_manager.py
Outdated
| if '=' not in cookie_header: | ||
| raise PMExcept('Malformed Cookie key in response headers; aborting.') | ||
| cookie = cookie_header.split('=')[1] | ||
| _log.debug('Logged in and received cookie: ' + cookie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Make changes per tagged issue.
How should this be manually tested?
Test endpoints on Swagger page
What are the relevant tickets?
#2254