2320 apiv3 frontend vstlpe #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good, I think the only thing left is updating the tests in test_tax_lot_property.py, which has references to api:v2.1:tax_lot_properties-export.
I didn't find scenarios used anywhere in tests or on the front end so I think we're good there.
While doing manual testing, I found an unrelated bug. I don't think you need to address it in this PR though: #2370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Part of the effort to convert the frontend to use API v3
What's this PR do?
See attached issue.
How should this be manually tested?
Verify checks in attached issue are warranted.
Also check the following:
Confirm that there are no usages of the scenarios endpoint outside the scope of swagger?
What are the relevant tickets?
#2320