Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project and compliance models #3743

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

nllong
Copy link
Member

@nllong nllong commented Jan 12, 2023

Any background context you want to provide?

We removed the concept of projects and compliance (tied to projects) from the front end in 2018. For some reason, we missed these files.

What's this PR do?

  • removes Projects* models from the codebase
  • removes Compliance model from the codebase
  • migration created to remove from database
  • tests removed/updated as needed

How should this be manually tested?

  • There is no explicit testing for this. Unit tests and monkey testing should suffice

What are the relevant tickets?

#3503

Screenshots (if appropriate)

- Fixed [#127]( https://github.com/SEED-platform/seed/issues/127 ), Export unmatched records
- Fixed [#258]( https://github.com/SEED-platform/seed/issues/258 ), Add Buildings to Projects from Project Screen
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These closed tickets should not have been in our CHANGELOG since they were closed without fixing/doing anything. I removed them from the text in our GitHub release as well.

@nllong nllong added the Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label. label Jan 12, 2023
@nllong nllong force-pushed the 3503-cleanup-old-projects-compliance branch from 20241d6 to a373606 Compare February 17, 2023 15:00
@nllong nllong force-pushed the 3503-cleanup-old-projects-compliance branch from 41d448c to 8dfd3d0 Compare February 17, 2023 15:40
Copy link
Member

@axelstudios axelstudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing more lines removed than added 🤌

@axelstudios axelstudios merged commit d1eafa2 into develop Feb 17, 2023
@axelstudios axelstudios deleted the 3503-cleanup-old-projects-compliance branch February 17, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants