Specify cycle in eui analysis #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haneslinger
added
the
Enhancement
anchapin
requested changes
Feb 6, 2023
| self.maxDiff = None | ||
| config = { | ||
| "select_meters": "date_range", | ||
| "meter": { |
There was a problem hiding this comment.
When I select date range I only see "select_meters = date_range" but not the start and end dates. Is that intentional? It would be good to show the start and end dates. See image below.
There was a problem hiding this comment.
I did not alter how the analysis are displayed, let me see if I can add it.
There was a problem hiding this comment.
This looks good now. However, can we have start_date first then end_date? I tried to figure out how to change this but couldn't figure it out quickly.
- Fixed multiple forced calendar popups when clicking `Select Meter Data Range`
- Fixed gaps between configuration list items in analysis details - Fixed broken analysis dialog from the legacy inventory list - Removed cycle ids from config list - Used `container-fluid` for proper layout
|
I fixed several issues, and added some improvements:
Thanks to @kflemin for the improved card layout: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
#3801 and #3800
Screenshots (if appropriate)