Fix importing of GeoJSON property footprints #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add bulk meter reading serializer for imports * fix validation on bulk_create method * make single writing naive too
|
ESPM appears to be down or at least the logging-in is just hanging. Rerun tomorrow morning. |
kflemin
approved these changes
Feb 14, 2023
axelstudios
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Footprints were being imported as
bounding_boxbut the column was never showing up it the mapping table. Note thatbounding_boxis not the right field if there are coordinates in a GeoJSON file.bounding_boxcomes from UBID decoding.What's this PR do?
Fixes the importing of the footprints from GeoJSON. I think historically we were testing with just CSV files.
How should this be manually tested?
See issue #3847. There is a test file in there and some instructions.
What are the relevant tickets?
#3847
Screenshots (if appropriate)
Fixed version should look like this
