-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter cycle specific labels on inventory list #3858
Conversation
I found a small bug: Says I have a filter group, "Called", which simply filters fro properties with the label "Call" |
1ceb236
to
4736b8c
Compare
This PR had two regressions:
It also doubled the inventory fetch requests on change. @perryr16 I added some fixes:
|
Any background context you want to provide?
The new Inventory List page's filter auto-complete shows all labels that are associated with any property, in any cycle. This differs from the functionality on Inventory List (legacy) page where only labels associated with the cycle's inventory are present.
What's this PR do?
$scope.data
) must first exist.How should this be manually tested?
What are the relevant tickets?
#3818
Screenshots (if appropriate)
NEW
2 cycles with unique and common labels.
OLD