Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom and panning to insights property page #3879

Merged
merged 2 commits into from
May 2, 2023

Conversation

haneslinger
Copy link
Contributor

Any background context you want to provide?

What's this PR do?

How should this be manually tested?

What are the relevant tickets?

Screenshots (if appropriate)

@haneslinger haneslinger added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Feb 23, 2023
@kflemin
Copy link
Contributor

kflemin commented Feb 24, 2023

@haneslinger, I can zoom but I can't pan...what's the command/motion for that?

@haneslinger
Copy link
Contributor Author

It's a hold and drag motion.... I find the library a little crunchy. can you do it in this demo? https://www.chartjs.org/chartjs-plugin-zoom/latest/samples/basic.html

@kflemin
Copy link
Contributor

kflemin commented Feb 24, 2023

@haneslinger, maybe it's because I have a trackpad... definitely a little crunchy but that's what they have in their library I guess? there's no way to "draw a rectangle region" and have the chart zoom to only show that region?

@RDmitchell
Copy link

Using my mouse I am able to zoom and pan.

The buttons (in the chart demo) are not very intuitive but maybe we can improve on that.

In general, I think this feature looks good, at least from the demo linked above.

@haneslinger
Copy link
Contributor Author

@haneslinger, maybe it's because I have a trackpad... definitely a little crunchy but that's what they have in their library I guess? there's no way to "draw a rectangle region" and have the chart zoom to only show that region?

I don't think there is with this plug in. 😞 there's with this one, but it's less popular... would you like me to try it out?

@anchapin
Copy link
Contributor

@haneslinger, maybe it's because I have a trackpad... definitely a little crunchy but that's what they have in their library I guess? there's no way to "draw a rectangle region" and have the chart zoom to only show that region?

I don't think there is with this plug in. 😞 there's with this one, but it's less popular... would you like me to try it out?

I do like the functionality in this other plug in with being able to draw a region to zoom and have the option to select points by drawing a rectangle (could be used to manually select points and add labels).

@kflemin
Copy link
Contributor

kflemin commented Feb 28, 2023

I like it too! To me it's much easier to use and less jumpy.

@haneslinger
Copy link
Contributor Author

cool cool, I'll swap it out

@haneslinger
Copy link
Contributor Author

oh no! despite claiming to be on npm, I don't think it is!
image

heslinge at 11:57:56 in ~/Repos/seed/vendors (develop) (seed)
🌟 npm install @jjppof/chartjs-plugin-zoom-pan-select
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@jjppof%2fchartjs-plugin-zoom-pan-select - Not found
npm ERR! 404
npm ERR! 404  '@jjppof/chartjs-plugin-zoom-pan-select@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/heslinge/.npm/_logs/2023-03-02T18_57_58_385Z-debug.log

image

what do we do?

@kflemin
Copy link
Contributor

kflemin commented Mar 2, 2023

@haneslinger can you install it from github just to try it out? it might not be kept up-to-date I guess 😬

@axelstudios
Copy link
Member

@haneslinger Is this PR finished and ready to merge? It's not clear if there are any changes planned for the zoom plugin.

This appears to work unless the data boundaries are below the minRange: 50 set by this PR, in which case zooming gets very weird... A lower minRange appears to fix it.

Also, the grid lines are pretty screwy:
PanGridLines

@haneslinger
Copy link
Contributor Author

Yeah, it's real screwy like, but it's the best plugin we've got. 🤷 Idk if we want to push it or not.

@axelstudios axelstudios merged commit cc1f6db into develop May 2, 2023
8 checks passed
@axelstudios axelstudios deleted the Add-zoom-to-property-insights-page branch May 2, 2023 20:53
@haneslinger haneslinger mentioned this pull request Jun 21, 2023
10 tasks
dhaley pushed a commit that referenced this pull request Jul 21, 2023
Co-authored-by: Alex Swindler <alex.swindler@nrel.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants