-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zoom and panning to insights property page #3879
Conversation
@haneslinger, I can zoom but I can't pan...what's the command/motion for that? |
It's a hold and drag motion.... I find the library a little crunchy. can you do it in this demo? https://www.chartjs.org/chartjs-plugin-zoom/latest/samples/basic.html |
@haneslinger, maybe it's because I have a trackpad... definitely a little crunchy but that's what they have in their library I guess? there's no way to "draw a rectangle region" and have the chart zoom to only show that region? |
Using my mouse I am able to zoom and pan. The buttons (in the chart demo) are not very intuitive but maybe we can improve on that. In general, I think this feature looks good, at least from the demo linked above. |
I don't think there is with this plug in. 😞 there's with this one, but it's less popular... would you like me to try it out? |
I do like the functionality in this other plug in with being able to draw a region to zoom and have the option to select points by drawing a rectangle (could be used to manually select points and add labels). |
I like it too! To me it's much easier to use and less jumpy. |
cool cool, I'll swap it out |
@haneslinger can you install it from github just to try it out? it might not be kept up-to-date I guess 😬 |
@haneslinger Is this PR finished and ready to merge? It's not clear if there are any changes planned for the zoom plugin. This appears to work unless the data boundaries are below the |
Yeah, it's real screwy like, but it's the best plugin we've got. 🤷 Idk if we want to push it or not. |
Co-authored-by: Alex Swindler <alex.swindler@nrel.gov>
Any background context you want to provide?
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)