Fix casting of GHG metrics on Program Insight page #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
changed the title
axelstudios
force-pushed
the
Fix-ghg-cast-and-exclude-non-numberic-from-eval
branch
from
8ccf108
to
8fb7fa7
Compare
|
@haneslinger I fixed one bug: The second numeric test was checking |
axelstudios
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Column cast to string by default. This means that if the insights page tries to call
/evaluateand one of the columns isn't custom cast, it'll 500. This fixed that by simply returning "unknown" instead and adding numeric casting for ghg and ghg_intensity.What's this PR do?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)