-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create property timeline view #3899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/SEED-platform/seed into 3795-edit-delete-scenarios-measures
…com/SEED-platform/seed into 3795-edit-delete-scenarios-measures
commit 21a366b Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 12:50:03 2023 -0600 refactor event tests for serializer changes commit 088d526 Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 11:49:17 2023 -0600 null true for audit date commit 3c8c86d Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 10:52:06 2023 -0600 protect against undefined filtering commit bcae8d2 Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 10:36:31 2023 -0600 filter check commit 5e9d1d8 Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 10:29:42 2023 -0600 precommit commit 2ca7931 Author: Ross Perry <perryr16@gmail.com> Date: Fri Mar 17 10:26:23 2023 -0600 troubleshooting test suite
# Conflicts: # locale/en_US/LC_MESSAGES/django.mo # locale/en_US/LC_MESSAGES/django.po # locale/fr_CA/LC_MESSAGES/django.mo # locale/fr_CA/LC_MESSAGES/django.po # seed/static/seed/js/controllers/inventory_detail_controller.js
…view-ui # Conflicts: # seed/migrations/0189_backfill_events.py
…b.com/SEED-platform/seed into 3843-Create-property-timeline-view-ui
- Fixed showing line breaks in notes - Fixed bottom border on Event Selection grid, and removed scrollbar - Fixed `Full Analysis` links - Fixed `undefined` upload messages for uploads without cycles - Fixed 500 error that permanently breaks a property if no scenarios are found - Fixed blank French translations - Fixed broken `cycle-` ids - Removed scrollbars and sorting from analysis/note ui-grids - Optimized images - Removed unused files - Updated package lockfiles to v3, sorted dependencies - Image optimization - Removed unused file
I fixed several issues:
Potential bugs/issues
|
axelstudios
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Add this label to new features. This will be reflected in the change log when generated.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
See #3769
What's this PR do?
How should this be manually tested?
setup:
Notes:
Analyses:
AT Uploads:
Timeline:
What are the relevant tickets?
#3769 Create Property Timeline Table
#3843 Create property timeline view UI
#3768 Create a new navigation item in property detail for Property Timeline
#3890 Edit Scenarios and measures on Property Details Page
#3777 Add a view set for measures
Screenshots (if appropriate)
Mockups
Property Detail Scenarios and Measures
Timeline Collapsed
Timeline Expanded
Event Selection