Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving BETTER/Salesforce data for non-active orgs #3925

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

axelstudios
Copy link
Member

What's this PR do?

This PR fixes the ability to save BETTER tokens, Salesforce configs, and Salesforce mappings for a different organization than the currently active one.

Additionally, it fixes a bug with sync_salesforce where the organization_id was being passed in the POST body rather than the path params.

How should this be manually tested?

  1. Go to the settings of an organization other than the active one in the top right corner
  2. Attempt to verify a BETTER token
  3. Attempt to save a Salesforce config and mappings
  4. Check the database and confirm that the org ids match the correct org, and not the one in the top right corner

What are the relevant tickets?

#3919
Related to #3916

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@axelstudios axelstudios merged commit 3d9de45 into develop Mar 22, 2023
@axelstudios axelstudios deleted the bugfix/3919-org-settings branch March 22, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants