Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom reports download button #3926

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

haneslinger
Copy link
Contributor

Any background context you want to provide?

Looks like a big change, but I just added a single div and indented the rest!

What's this PR do?

How should this be manually tested?

What are the relevant tickets?

#3910

Screenshots (if appropriate)

image

@kflemin
Copy link
Contributor

kflemin commented Mar 22, 2023

@haneslinger, could you add the button inside the "actions area instead of underneath? I think it would look better inside that little frame. thanks!

@axelstudios
Copy link
Member

axelstudios commented Mar 23, 2023

@haneslinger I'm definitely glad that this is in the Actions box, but can we set a max width? It looks crazy on an ultrawide monitor:
image
flex: 0 or similar on the container ought to do it

Copy link
Member

@axelstudios axelstudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great

@axelstudios axelstudios merged commit f503433 into develop Mar 23, 2023
@axelstudios axelstudios deleted the 3910-FIX-custom-reports-download-button branch March 23, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants