Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions Masking #3930

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Mar 23, 2023

What's this PR do?

Moves SF_DOMAIN from secrets to vars

How should this be manually tested?

If the CI passes (and test names are unobscured) it's good to go

What are the relevant tickets?

#3929

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@axelstudios axelstudios merged commit 98fc545 into develop Mar 23, 2023
@axelstudios axelstudios deleted the bugfix/3929-github-actions-mask branch March 23, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants