Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing a derived column without changing the name #3949

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

axelstudios
Copy link
Member

Any background context you want to provide?

Attempting to edit an already-saved column, without changing the name, always resulted in an error because the name was already taken by itself.

What's this PR do?

  • Fixes updating an existing derived column when the name is unchanged
  • Fixes Derived Columns active nav for all subpages
  • Improves the Create Derived Column button to set the default type on the editor page based on whether it was clicked when viewing the Property or Tax Lot derived columns
  • Improves the Create/Save button such that it takes you to the correct Property/Tax Lot derived column page on success

How should this be manually tested?

  • Create a derived column, click Edit, then click Save. It should now succeed
  • Check that the Derived Columns nav shows as active while on any of the derived column pages
  • Check that the Create Derived Column button initializes the Type field depending on which tab you were using when you clicked it
  • Check that saving a derived column takes you to the correct tab where it appears

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After your changes, the derived column can be saved with the same name!
image

Nav stays active ✅
saving takes to correct tab ✅
Property/TaxLot Type is initialized correctly ✅

@nllong nllong merged commit 0cf7141 into develop Mar 31, 2023
@nllong nllong deleted the bugix/save-derived-column branch March 31, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants