Save Insight property config locally #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found: |
haneslinger
added
the
Enhancement
|
doh, I forgot to include the saving of way datasets you have hidden. I'll add that soon |
|
done! |
axelstudios
requested changes
May 2, 2023
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
| dataset_visibility: new_configs.dataset_visibility, | ||
| annotation_visibility: new_configs.annotation_visibility, | ||
| } | ||
| localStorage.setItem('insights.property.configs', JSON.stringify(local_storage_configs)); |
There was a problem hiding this comment.
Since this localStorage key doesn't include the org id (or a nested structure using the org id as a lookup) these settings will be lost any time someone changes their org and visits this page
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
seed/static/seed/js/controllers/insights_property_controller.js
Outdated
Show resolved
Hide resolved
kflemin
approved these changes
May 3, 2023
axelstudios
approved these changes
May 3, 2023
dhaley
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Save Insight property config locally * Save visiibility locally * Formatting * Fix for mutliple orgs * Fixed annotation_visibility bug --------- Co-authored-by: Alex Swindler <alex.swindler@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
On the property insights page, the things you select in the dropdown are now saved locally. 👍
What's this PR do?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)