Add ranked sorting to insight property page #4030
Conversation
|
Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found: |
| } | ||
| } | ||
| // Rank | ||
| if($scope.configs.chart_xaxis === "Ranked"){ |
There was a problem hiding this comment.
above, L250, we're calculating x, then recalculating here should it be ranked. idk how to only do it once, as the normal x value must be calculated in the for loop so we have access to the property, and the ranked must happen after so it can sort. any thoughts?
haneslinger
added
the
Enhancement
|
@kflemin repinging this. |
* Add ranked sorting to insight property page * Fix for chrome
|
@haneslinger -- I guess I'm being stupid, but I don't understand what the ranking is based on ? Here is an example from the Test BPS org |
|
lol, I had to work with @isalanglois to figure out exactly what was being asked for here. It the properties list where the first is the fartherest from compliance and the last is the closest. Its not the most intuitive. Any ideas how we can make it better? |
|
@haneslinger -- I thought it might be something like that, but then I was confused by the left most point, because the "Distance to Target" line wasn't being displayed, maybe because it's sitting right on the axis. I'm not sure how else what is being asked for could be shown. It's probably one of those things that we need to get feedback from the users who wanted it to see if it meets their expectations. Thanks !! |
Any background context you want to provide?
What's this PR do?
Adds a hard coded x-axis option, "Ranked" which ranks non-compliant propertyby their non compliance.
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)