Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin urllib3 #4059

Merged
merged 2 commits into from
May 23, 2023
Merged

Pin urllib3 #4059

merged 2 commits into from
May 23, 2023

Conversation

axelstudios
Copy link
Member

Any background context you want to provide?

Dependabot updated requests, and requests v2.30.0 added support for urllib3 v2.0.

https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#attributeerror-module-urllib3-connectionpool-has-no-attribute-verifiedhttpsconnection

kevin1024/vcrpy#688

What's this PR do?

Pins urllib3 to v1 to fix the one CI test failure until vcrpy fixes their broken imports

How should this be manually tested?

CI success

@axelstudios axelstudios requested a review from kflemin May 23, 2023 18:46
@axelstudios axelstudios added the Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label. label May 23, 2023
@SEED-platform SEED-platform deleted a comment from github-actions bot May 23, 2023
@axelstudios axelstudios merged commit 1f888a1 into develop May 23, 2023
7 of 8 checks passed
@axelstudios axelstudios deleted the bugfix/lock-urllib3 branch May 23, 2023 20:28
dhaley pushed a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants