Fix Download URLs #4066
Merged
Fix Download URLs #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
force-pushed
the
bugfix/fix-import-file-downloads
branch
from
422e5a1
to
34ac4b9
Compare
dhaley
pushed a commit
that referenced
this pull request
Jul 21, 2023
Fixed download urls with backslashes and more than 1 level of nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The import-file download buttons on the Dataset Detail page weren't working for any files stored in directories with more than one level of nesting from the media directory.
For example, a PM import stored in
/seed/media/uploads/pm_imports/pm_import_2023-05-30.csvwas incorrectly linking to/api/v3/media/pm_imports/pm_import_2023-05-30.csv(missing theuploadsdirectory).What's this PR do?
Fixes all download links regardless of nesting and mixed slashes
How should this be manually tested?