Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching criteria to report export #4072

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

haneslinger
Copy link
Contributor

Any background context you want to provide?

What's this PR do?

How should this be manually tested?

see ticket

What are the relevant tickets?

#3869

Screenshots (if appropri

image ate)

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Label error. Requires at least 1 of: Feature, Bug, Enhancement, Maintenance, Documentation, Performance, Do not publish. Found:

@haneslinger haneslinger requested a review from perryr16 June 2, 2023 15:52
@haneslinger haneslinger added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Jun 2, 2023
@haneslinger haneslinger marked this pull request as ready for review June 2, 2023 18:28
@kflemin kflemin self-requested a review June 15, 2023 22:01
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that all matching fields end up in the exported spreadsheet!

@axelstudios axelstudios merged commit ef5476c into develop Jun 21, 2023
7 checks passed
@axelstudios axelstudios deleted the FIX-3869-Add-macthing-criteria-to-reports-export branch June 21, 2023 21:32
dhaley pushed a commit that referenced this pull request Jul 21, 2023
* Add matching criteria to report export

* Fix test

---------

Co-authored-by: Katherine Fleming <2205659+kflemin@users.noreply.github.com>
Co-authored-by: Alex Swindler <alex.swindler@nrel.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants