Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Creation Bugs #4094

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix User Creation Bugs #4094

merged 2 commits into from
Jun 14, 2023

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Jun 9, 2023

What's this PR do?

Fixes multiple bugs:

  1. It was not possible to use the Admin Create a user form when also specifying a new organization to create
  2. The same Create a user form failed to update the organization list after creating a new organization
  3. The create_default_user script failed to add new users to the specified organization if it already existed, leaving the new user orphaned

How should this be manually tested?

  1. Check that the Create a user form works as expected when specifying a new organization name, and then check the organization dropdown at the top right for the newly created org
  2. Check that an organization owner (non-superuser) can still invite new members to their organization
  3. Run manage.py create_default_user, specifying and existing organization name, and check that the new user was added to the organization as an owner

What are the relevant tickets?

#4095

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this worked for me!

@axelstudios axelstudios merged commit ee01b9e into develop Jun 14, 2023
7 checks passed
@axelstudios axelstudios deleted the bugfix/user-org-creation branch June 14, 2023 22:18
dhaley pushed a commit that referenced this pull request Jul 21, 2023
* Fixed multiple user creation bugs

* Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants