Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease BETTER polling rate 5x, increase timeout 5x #4280

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

axelstudios
Copy link
Member

Any background context you want to provide?

BETTER's API can begin limiting API requests for long periods of time once a certain threshold of requests have been sent for a specific API key.

What's this PR do?

Reduces the polling rate for BETTER results from every second to every 5 seconds, and increases the timeout from 1 minute to 5 minutes.

How should this be manually tested?

Monitor backend network requests when performing a BETTER analysis.

@axelstudios axelstudios added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Oct 12, 2023
@SEED-platform SEED-platform deleted a comment from github-actions bot Oct 12, 2023
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, works as expected. This will save a lot of requests hitting the BETTER api and prevent normal users from getting throttled.

@nllong nllong merged commit 1945664 into develop Oct 12, 2023
7 of 8 checks passed
@nllong nllong deleted the task/decrease-better-polling branch October 12, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants