Add failing logic to AT export if AT credentials are invalid #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
perryr16
commented
Oct 13, 2023
docker-compose.dev.yml
Outdated
| @@ -22,7 +22,6 @@ services: | |||
| environment: | |||
| - DJANGO_SETTINGS_MODULE=config.settings.docker_dev | |||
| - DJANGO_LOG_LEVEL | |||
| - EEEJ_LOAD_SMALL_TEST_DATASET=True | |||
There was a problem hiding this comment.
Should the docker-compose.dev.yml include this env var?
There was a problem hiding this comment.
I think so because that is what we use for our GitHub regression testing, right? We want that to run faster.
nllong
requested changes
Oct 19, 2023
|
@perryr16 -- do you know why I would be getting this error? I know that my username and PW are right. Is there something to do with the org that I have? |
|
@nllong Are you using my org token? Is your |
nllong
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
If a user's AT credentials were invalid the page would hang
What's this PR do?
Fails gracefully if credentials are invalid
How should this be manually tested?
Inventory List > selection > Actions > Export to Audit Template. Once with invalid credentials, and once with valid credentials
What are the relevant tickets?
Screenshots (if appropriate)