Provide environment variable to disable wait-for-it condition in deployments #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflemin
approved these changes
Nov 2, 2023
nllong
requested changes
Nov 2, 2023
docker/start_celery_docker.sh
Outdated
| then | ||
| POSTGRES_ACTUAL_HOST=$POSTGRES_HOST | ||
| # Check if 'STRATUS_MANAGED_SERVICES_ENABLED' is not set or if its value is 'TRUE' | ||
| if [[ "${STRATUS_MANAGED_SERVICES_ENABLED}" == "on" ]]; then |
There was a problem hiding this comment.
can we name this something not NREL-specific... others use this code as well. Something like DISABLE_SERVICE_CHECKS_ON_START or something? And add a warning that one should not do this unless they are sure their services are running.
There was a problem hiding this comment.
Sure. That's a better name. Let me fix that.
There was a problem hiding this comment.
thanks, this is much more applicable to our external users too!
nllong
changed the title
nllong
added
Feature
dhaley
force-pushed
the
feature/stratus-faster-startup-time
branch
from
8ca98e5
to
a1815d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix bug in stratus where celery container halted as wait-for-it script couldn't make socket connection to main connection.
What's this PR do?
This fix disables wait-for-it scripts that are not needed as managed services such as Postgres, Redis are not in docker and are already running. So wait-for-it scrips are not needed in Stratus environment.
How should this be manually tested?
Build Docker image of seed and deploy to Stratus.
What are the relevant tickets?
Screenshots (if appropriate)