Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Report Name Field Location #4385

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Custom Report Name Field Location #4385

merged 7 commits into from
Nov 30, 2023

Conversation

kflemin
Copy link
Contributor

@kflemin kflemin commented Nov 8, 2023 •
edited

Affiliated issue: #3613

  • Update the location of the "Name" input field
  • Disable editing unless in "edit" mode
  • Fix bugs related to name field not populating when switching between reports or creating a new one

Looks like this now:

DISPLAY MODE
Screen Shot 2023-11-08 at 9 54 18 AM

EDITING MODE
Screen Shot 2023-11-08 at 9 54 35 AM

@kflemin kflemin added the Bug label Nov 8, 2023
@kflemin kflemin requested a review from anchapin November 8, 2023 17:37
@kflemin kflemin added the SCEP label Nov 8, 2023
@kflemin kflemin mentioned this pull request Nov 15, 2023
Open
haneslinger
haneslinger approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@haneslinger haneslinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

seed/static/seed/partials/data_view.html Outdated
Comment on lines 56 to 57
<!--<div class="r-row r-row-centered r-margin-bottom-10">-->
<!-- <label for="input-name" class="r-pad-right-5" translate>Name</label> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this?

@kflemin kflemin merged commit 687117e into develop Nov 30, 2023
7 checks passed
@kflemin kflemin deleted the 3613-custom-report-name branch November 30, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haneslinger haneslinger haneslinger approved these changes

@anchapin anchapin Awaiting requested review from anchapin

Assignees
No one assigned
Labels
Bug SCEP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kflemin @haneslinger