Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesforce scheduling issues #4387

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

axelstudios
Copy link
Member

What's this PR do?

  • Fixes an issue where attempting to set a Salesforce sync time with hour = 0 or minute = 0 would (in most cases) not actually take effect
  • Fixes an issue where each time a Salesforce config is saved with a cron schedule that hasn't previously been used it orphans the old schedule, resulting in tons of unused records in the crontabschedule table:
    image
  • Improves the UI to use restricted numeric inputs for hours/minutes, which fixes mixed data types when saving a Salesforce config:
    image

How should this be manually tested?

  1. Modify the hour/minute of a Salesforce scheduled update and:
    1. Check that the PUT request uses integers for update_at_hour and update_at_minute
    2. Check that setting the hour or minute to 0 correctly updates the crontabschedule table
    3. Check that the crontabschedule table has no entries that aren't referenced by the periodictask table

@axelstudios axelstudios merged commit 748043e into develop Nov 28, 2023
7 checks passed
@axelstudios axelstudios deleted the bugfix/salesforce-schedule branch November 28, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants