Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed FontAwesome v6.5 alignment #4444

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fixed FontAwesome v6.5 alignment #4444

merged 2 commits into from
Dec 15, 2023

Conversation

axelstudios
Copy link
Member

Any background context you want to provide?

FontAwesome automatically updated from v6.4.2 to v6.5.0, which caused alignment issues and visible scrollbars:
image

What's this PR do?

Fixes the alignment for the latest version of FontAwesome

How should this be manually tested?

  1. Run npm install
  2. Check that tiny scrollbars no longer appear on the homepage

@axelstudios axelstudios added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label Dec 14, 2023
kflemin
kflemin approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@axelstudios axelstudios merged commit acd8337 into develop Dec 15, 2023
7 checks passed
@axelstudios axelstudios deleted the task/font-awesome-improvements branch December 15, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees
No one assigned
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axelstudios @kflemin @nllong