Apply GHG and GHGI unit versions to canonical columns #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryr16
changed the title
haneslinger
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
GHG and GHGI units were selctable un column settings and mappings, however displayed values did not reflect these settings.
What's this PR do?
Applies unit conversion for canonical GHG and GHGI columns during the backend's retrieval from the db.
NOTEThis does not work for extra data columns. This is a known issue and needs further discussion.How should this be manually tested?
Upload a file with canonical columns "Total GHG Emissions" and "Total GHG Emissions Intensity" (or map to those canonical columns) then use the org settings to change the display units. The values on the inventory list and details should be updated.
What are the relevant tickets?
#2605
Screenshots (if appropriate)
settings
GHG - Mt/year & GHGI - Mt/ft2/year
GHG - kg/year & GHGI - Mt/m2/year
GHG - kg/year & GHGI - kg/ft2/year
GHG - kg/year & GHGI - kg/m2/year