Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore column filters when unpinning #4473

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented Jan 9, 2024

Any background context you want to provide?

UI Grid has a known bug where unpinning a pinned column causes the filter box to disappear (until you either scroll away from the column and back, or refresh the page).

What's this PR do?

  • Adds a workaround to handle a preexisting bug in UI grid by unpinning, hiding the column, and restoring the column. This is necessary because the underlying issue is a race condition with the filter destructor, and the column has to be recreated.
  • This PR also hides the Pin Right menu option, since we don't respect that option

How should this be manually tested?

  1. On the Inventory List page, pin a column
  2. Unpin the same column, check that the filter box is still present

If there are other grids in SEED that allow pinning and filtering they should be updated as well.

What are the relevant tickets?

#3760

@axelstudios axelstudios merged commit e500512 into develop Jan 10, 2024
8 checks passed
@axelstudios axelstudios deleted the bugfix/3760-fix-unpinned-filters branch January 10, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants